Re: Replication slot stats misgivings

On Thu, Apr 15, 2021 at 02:46:35PM +0530, Amit Kapila wrote:
> On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > Thank you for updating the patch.
> >
> > I have one question on the doc change:
> >
> > + so the counter is not incremented for subtransactions. Note that this
> > + includes the transactions streamed and or spilled.
> > + </para></entry>
> >
> > The patch uses the sentence "streamed and or spilled" in two places.
> > You meant “streamed and spilled”? Even if it actually means “and or”,
> > using "and or” (i.g., connecting “and” to “or” by a space) is general?
> > I could not find we use it other places in the doc but found we're
> > using "and/or" instead.
> >
>
> I changed it to 'and/or' and made another minor change.

I'm suggesting some doc changes. If these are fine, I'll include in my next
round of doc review, in case you don't want to make another commit just for
that.

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 1d90eb0f21..18c5bba254 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -2720,9 +2720,9 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
</para>
<para>
Number of decoded transactions sent to the decoding output plugin for
- this slot. This counter is used to maintain the top level transactions,
- so the counter is not incremented for subtransactions. Note that this
- includes the transactions that are streamed and/or spilled.
+ this slot. This counts top-level transactions only,
+ and is not incremented for subtransactions. Note that this
+ includes transactions that are streamed and/or spilled.
</para></entry>
</row>

@@ -2731,10 +2731,10 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
<structfield>total_bytes</structfield><type>bigint</type>
</para>
<para>
- Amount of decoded transactions data sent to the decoding output plugin
+ Amount of decoded transaction data sent to the decoding output plugin
while decoding the changes from WAL for this slot. This can be used to
gauge the total amount of data sent during logical decoding. Note that
- this includes the data that is streamed and/or spilled.
+ this includes data that is streamed and/or spilled.
</para>
</entry>
</row>
--
2.17.0