| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Possible typo/unclear comment in joinpath.c |
| Date: | 2021-04-14 16:42:53 |
| Message-ID: | 20210414164253.GI6091@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 14, 2021 at 11:36:38AM -0400, James Coleman wrote:
> In joinpath.c three times we reference "extra_lateral_rels" (with
> underscores like it's a field), but as far as I can tell that's not a
> field anywhere in the source code, and looking at the code that
> follows it seems like it should be referencing "lateral_relids" (and
> the "extra" is really "extra [in relation to relids]").
It looks like a loose end from
commit edca44b1525b3d591263d032dc4fe500ea771e0e
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: Mon Dec 7 18:56:14 2015 -0500
Simplify LATERAL-related calculations within add_paths_to_joinrel().
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2021-04-14 16:52:59 | Re: jsonb subscripting assignment performance |
| Previous Message | Honza Horak | 2021-04-14 16:21:58 | Options given both on cmd-line and in the config with different values |