| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Charlie Hornsby <charlie(dot)hornsby(at)hotmail(dot)co(dot)uk> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade check for invalid role-specific default config |
| Date: | 2021-04-12 21:16:02 |
| Message-ID: | 20210412211602.GC22319@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 12, 2021 at 01:28:19PM +0000, Charlie Hornsby wrote:
> Hi all,
>
> While troubleshooting a failed upgrade from v11 -> v12 I realised I had
> encountered a bug previously reported on the pgsql-bugs mailing list:
>
> #14242 Role with a setconfig "role" setting to a nonexistent role causes
> pg_upgrade to fail
>
> https://www.postgresql.org/message-id/20160711223641.1426.86096%40wrigleys.postgresql.org
...
> Since it is possible to write a query to identify these cases, would there
> be appetite for me to submit a patch to add a check for this to
> pg_upgrade?
>
> First time mailing list user here so many apologies for any missteps I have
> made in this message.
Yes, I think a patch would be good, but the fix might be for pg_dump
instead, which pg_upgrade uses.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-12 21:29:15 | Re: pg_upgrade check for invalid role-specific default config |
| Previous Message | Tom Lane | 2021-04-12 21:14:20 | Re: Allowing to create LEAKPROOF functions to non-superuser |