Re: pgsql: autovacuum: handle analyze for partitioned tables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: autovacuum: handle analyze for partitioned tables
Date: 2021-04-10 00:01:04
Message-ID: 20210410000104.GA7025@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hello

On 2021-Apr-09, Andres Freund wrote:

> I assume this is also the likely explanation for / fix for:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2021-04-08%2016%3A03%3A03
>
> ==3500389== VALGRINDERROR-BEGIN
> ==3500389== Invalid read of size 8
> ==3500389== at 0x4EC4B8: relation_needs_vacanalyze (autovacuum.c:3237)
> ==3500389== by 0x4EE0AF: do_autovacuum (autovacuum.c:2168)
> ==3500389== by 0x4EEEA8: AutoVacWorkerMain (autovacuum.c:1715)
> ==3500389== by 0x4EEF7F: StartAutoVacWorker (autovacuum.c:1500)
> ==3500389== by 0x4FD2E4: StartAutovacuumWorker (postmaster.c:5539)

Hmm, I didn't try to reproduce this, but yeah it sounds quite likely
that it's the same issue -- line 3237 is the GETSTRUCT call where the
other one was crashing, which is now gone.

Thanks for pointing it out,

--
Álvaro Herrera Valdivia, Chile

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Laurenz Albe 2021-04-10 01:38:31 Re: pgsql: SQL-standard function body
Previous Message Andres Freund 2021-04-09 23:47:28 Re: pgsql: autovacuum: handle analyze for partitioned tables

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-04-10 01:39:19 Re: Table refer leak in logical replication
Previous Message Andres Freund 2021-04-09 23:47:28 Re: pgsql: autovacuum: handle analyze for partitioned tables