Re: Autovacuum on partitioned table (autoanalyze)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: yuzuko <yuzukohosoya(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Amit Langote <amitlangote09(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Greg Stark <stark(at)mit(dot)edu>
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Date: 2021-04-08 21:30:51
Message-ID: 20210408213051.GL6592@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 08, 2021 at 01:20:14AM -0400, Alvaro Herrera wrote:
> On 2021-Apr-07, Alvaro Herrera wrote:
>
> > OK, I bit the bullet and re-did the logic in the way I had proposed
> > earlier in the thread: do the propagation on the collector's side, by
> > sending only the list of ancestors: the collector can read the tuple
> > change count by itself, to add it to each ancestor. This seems less
> > wasteful. Attached is v16 which does it that way and seems to work
> > nicely under my testing.
>
> Pushed with this approach. Thanks for persisting with this.

commit 0827e8af70f4653ba17ed773f123a60eadd9f9c9
| This also introduces necessary reloptions support for partitioned tables
| (autovacuum_enabled, autovacuum_analyze_scale_factor,
| autovacuum_analyze_threshold). It's unclear how best to document this
| aspect.

At least this part needs to be updated - see also ed62d3737.

doc/src/sgml/ref/create_table.sgml- The storage parameters currently
doc/src/sgml/ref/create_table.sgml- available for tables are listed below.
...
doc/src/sgml/ref/create_table.sgml: Specifying these parameters for partitioned tables is not supported,
doc/src/sgml/ref/create_table.sgml- but you may specify them for individual leaf partitions.

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-04-08 21:32:13 Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays
Previous Message Alvaro Herrera 2021-04-08 21:29:51 Re: pgsql: autovacuum: handle analyze for partitioned tables