| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Hannu Krosing <hannuk(at)google(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Date: | 2021-04-08 01:00:40 |
| Message-ID: | 20210408010040.GH24239@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 7, 2021 at 08:54:02PM -0400, Bruce Momjian wrote:
> > > I am also confused about the inconsistency of calling the GUC
> > > compute_query_id (with underscore), but pg_stat_activity.queryid. If we
> > > make it pg_stat_activity.query_id, it doesn't match most of the other
> > > *id columsns in the table, leader_pid, usesysid, backend_xid. Is that
> > > OK?I know I suggested pg_stat_activity.query_id, but maybe I was wrong.
> >
> > Mmm, most of the columns in pg_stat_activity do have a "_", so using query_id
> > would make more sense.
>
> OK, let me work on a patch to change that part.
Uh, it is 'queryid' in pg_stat_statements:
https://www.postgresql.org/docs/13/pgstatstatements.html
queryid bigint
Internal hash code, computed from the statement's parse tree
I am not sure if we should have pg_stat_activity use underscore, or the
GUC use underscore. The problem is that queryid can easily look like
quer-yid.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2021-04-08 01:06:56 | Typo in jsonfuncs.c |
| Previous Message | Bruce Momjian | 2021-04-08 00:54:02 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |