Re: Issue with point_ops and NaN

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: rjuju123(at)gmail(dot)com
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, laurenz(dot)albe(at)cybertec(dot)at, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Issue with point_ops and NaN
Date: 2021-04-01 00:34:40
Message-ID: 20210401.093440.1120587802627564091.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 31 Mar 2021 16:30:41 +0800, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote in
> On Wed, Mar 31, 2021 at 03:48:16PM +0900, Kyotaro Horiguchi wrote:
> >
> > Thanks! However, Michael's suggestion is worth considering. What do
> > you think about makeing NaN-involved comparison return NULL? If you
> > agree to that, I'll make a further change to the patch.
>
> As I mentioned in [1] I think that returning NULL would the right thing to do.
> But you mentioned elsewhere that it would need a lot more work to make the code
> work that way, so given that we're 7 days away from the feature freeze maybe
> returning false would be a better option. One important thing to consider is

Agreed that it's a better option.

I have to change almost all boolean-returning functions to
tri-state-boolean ones. I'll give it try a bit futther.

> that we should consistently return NULL for similar cases, and having some
> discrepancy there would be way worse than returning false everywhere.

Sure.

> [1] https://www.postgresql.org/message-id/20210330153940.vmncwnmuw3qnpkfa@nol

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-04-01 00:35:32 Re: Issue with point_ops and NaN
Previous Message David Rowley 2021-03-31 23:49:49 Re: Hybrid Hash/Nested Loop joins and caching results from subplans