| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Replication slot stats misgivings |
| Date: | 2021-03-30 05:30:24 |
| Message-ID: | 20210330053024.bl5qmq3frsmfk54d@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-03-30 10:13:29 +0530, vignesh C wrote:
> On Tue, Mar 30, 2021 at 6:28 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Any chance you could write a tap test exercising a few of these cases?
>
> I can try to write a patch for this if nobody objects.
Cool!
> > E.g. things like:
> >
> > - create a few slots, drop one of them, shut down, start up, verify
> > stats are still sane
> > - create a few slots, shut down, manually remove a slot, lower
> > max_replication_slots, start up
>
> Here by "manually remove a slot", do you mean to remove the slot
> manually from the pg_replslot folder?
Yep - thereby allowing max_replication_slots after the shutdown/start to
be lower than the number of slots-stats objects.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-30 05:58:37 | Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. |
| Previous Message | vignesh C | 2021-03-30 05:09:17 | Re: [HACKERS] logical decoding of two-phase transactions |