| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, kuroda(dot)hayato(at)fujitsu(dot)com, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |
| Date: | 2021-03-26 17:14:36 |
| Message-ID: | 20210326171436.7gff4d2b2zh4ooma@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-03-26 09:27:19 +0900, Masahiro Ikeda wrote:
> On 2021/03/25 19:48, Fujii Masao wrote:
> > Yes. So we should wait for the shared memory stats patch to be committed
> > before working on walreceiver stats patch more?
>
> Yes, I agree.
Agreed.
One thing that I didn't quite see discussed enough in the thread so far:
Have you considered what regressions the stats file removal in immediate
shutdowns could cause? Right now we will - kind of accidentally - keep
the stats file for immediate shutdowns, which means that autovacuum etc
will still have stats to work with after the next start. After this, not
so much?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-03-26 17:16:40 | Re: Walsender may fail to send wal to the end. |
| Previous Message | Andres Freund | 2021-03-26 17:11:25 | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |