From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net> |
Cc: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Haas <robert(dot)haas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] More docs on what to do and not do in extension code |
Date: | 2021-03-25 22:15:49 |
Message-ID: | 20210325221549.GB18243@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 25, 2021 at 08:49:44AM -0400, David Steele wrote:
> On 1/22/21 1:36 AM, Craig Ringer wrote:
> >
> > Would you mind attaching a revised version of the patch with your edits?
> > Otherwise I'll go and merge them in once you've had your say on my
> > comments inline below.
>
> Bharath, do the revisions in [1] look OK to you?
>
> > Bruce, Robert, can I have an opinion from you on how best to locate and
> > structure these docs, or whether you think they're suitable for the main
> > docs at all? See patch upthread.
>
> Bruce, Robert, any thoughts here?
I know I sent an email earlier this month saying we shouldn't
over-document the backend hooks because the code could drift away from
the README content:
https://www.postgresql.org/message-id/20210309172049.GD26575%40momjian.us
Agreed. If you document the hooks too much, it allows them to drift
away from matching the code, which makes the hook documentation actually
worse than having no hook documentation at all.
However, for this doc patch, the content seem to be more strategic, so
less likely to change, and hard to figure out from the code directly.
Therefore, I think this would be a useful addition to the docs.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
From | Date | Subject | |
---|---|---|---|
Next Message | Markus Wanner | 2021-03-25 22:15:50 | Re: [PATCH] add concurrent_abort callback for output plugin |
Previous Message | Bruce Momjian | 2021-03-25 21:40:37 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |