Re: Nicer error when connecting to standby with hot_standby=off

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, James Coleman <jtc331(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Nicer error when connecting to standby with hot_standby=off
Date: 2021-03-24 07:59:01
Message-ID: 20210324075901.GA10074@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Mar-24, Fujii Masao wrote:

> On 2021/03/24 5:59, Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > FATAL: the database system is starting up
> > > DETAIL: WAL is being applied to recover from a system crash.
> > > or
> > > DETAIL: The system is applying WAL to recover from a system crash.
> > > or
> > > DETAIL: The startup process is applying WAL to recover from a system crash.
> >
> > I don't think the postmaster has enough context to know if that's
> > actually true. It just launches the startup process and waits for
> > results. If somebody saw this during a normal (non-crash) startup,
> > they'd be justifiably alarmed.
>
> Yes, so logging "the database system is starting up" seems enough to me.

No objection.

--
Álvaro Herrera Valdivia, Chile
"Cuando no hay humildad las personas se degradan" (A. Christie)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-03-24 08:12:35 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Previous Message Fujii Masao 2021-03-24 07:52:56 Re: Failed assertion on standby while shutdown