| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Bernd Helmle <mailings(at)oopsware(dot)de>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Change default of checkpoint_completion_target |
| Date: | 2021-03-22 17:11:00 |
| Message-ID: | 20210322171059.GB20766@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* David Steele (david(at)pgmasters(dot)net) wrote:
> I had a look at the patch and the change and new documentation seem sensible
> to me.
Thanks!
> I think this phrase may be a bit too idiomatic:
>
> + consistent I/O load while also leaving some slop for checkpoint
>
> Perhaps just:
>
> + consistent I/O load while also leaving some time for checkpoint
Yeah, good thought, updated.
> It seems to me that the discussion about changing the wording for GUCs not
> changeable after server should be saved for another patch as long as this
> patch follows the current convention.
Agreed.
Unless there's anything further on this, I'll plan to commit it tomorrow
or Wednesday.
Thanks!
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| cct_def_v5.patch | text/x-diff | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-03-22 17:12:10 | Re: Protect syscache from bloating with negative cache entries |
| Previous Message | Laurenz Albe | 2021-03-22 17:09:23 | Re: Disable WAL logging to speed up data loading |