Re: [HACKERS] Custom compression methods

On Mon, Mar 22, 2021 at 11:05:19AM -0400, Robert Haas wrote:
> On Mon, Mar 22, 2021 at 10:44 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > Thanks. I just realized that if you also push the GUC change, then the docs
> > should change from <string> to <enum>
> >
> > doc/src/sgml/config.sgml: <term><varname>default_toast_compression</varname> (<type>string</type>)
>
> I've now also committed your 0005. As for 0006, aside from the note
> above, which is a good one, is there any particular reason why this
> patch is labelled as WIP? I think this change makes sense and we
> should just do it unless there's some problem with it.

The first iteration was pretty rough, and there's still some question in my
mind about where default_toast_compression_options[] should be defined. If
it's in the header file, then I could use lengthof() - but then it probably
gets multiply defined. In the latest patch, there's multiple "externs". Maybe
guc.c doesn't need the extern, since it includes toast_compression.h. But then
it's the only "struct config_enum_entry" which has an "extern" outside of
guc.c.

Also, it looks like you added default_toast_compression out of order, so maybe
you'd fix that at the same time.

--
Justin