Re: [HACKERS] Custom compression methods

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-03-19 22:43:40
Message-ID: 20210319224340.GO11765@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 19, 2021 at 10:19:49PM +0100, Tomas Vondra wrote:
> On 3/19/21 9:40 PM, Andres Freund wrote:
> > On 2021-03-19 17:35:58 -0300, Alvaro Herrera wrote:
> >> I find this behavior confusing; I'd rather have configure error out if
> >> it can't find the package support I requested, than continuing with a
> >> set of configure options different from what I gave.
> >
> > +1
>
> Yeah. And why does it even require pkg-config, unlike any other library
> that I'm aware of?

The discussion regarding pkg-config started here.
https://www.postgresql.org/message-id/20210309071655.GL2021%40telsasoft.com

I sent a patch adding it to allow the macos CI to build --with-lz4.
Since LZ4 was only recently installed on the CI environments, it's possible
that's not the ideal way to do it.

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-03-19 22:51:57 Re: [HACKERS] Custom compression methods
Previous Message Alvaro Herrera 2021-03-19 22:38:43 Re: [HACKERS] Custom compression methods