From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | masao(dot)fujii(at)oss(dot)nttdata(dot)com, gkokolatos(at)protonmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: shared-memory based stats collector |
Date: | 2021-03-18 08:47:20 |
Message-ID: | 20210318084720.szerq2q3qm2prtp4@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2021-03-18 16:56:02 +0900, Kyotaro Horiguchi wrote:
> At Tue, 16 Mar 2021 10:27:55 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > At Mon, 15 Mar 2021 17:49:36 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > > Thanks for committing this! I'm very happy to see this reduces the
> > > size of this patchset.
> >
> > Now that 0003 is committed as d75288fb27, and 33394ee6f2 conflicts
> > with old 0004, I'd like to post a rebased version for future work.
> >
> > The commit 33394ee6f2 adds on-exit forced write of WAL stats on
> > walwriter and in this patch that part would appear to have been
> > removed. However, this patchset already does that by calling to
> > pgstat_report_stat from pgstat_beshutdown_hook.
>
> Rebased and fixed two bugs. Not addressed received comments in this
> version.
Since I am heavily editing the code, could you submit "functional"
changes (as opposed to fixing rebase issues) as incremental patches?
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2021-03-18 08:48:57 | Re: SSL SNI |
Previous Message | 杨逸存 | 2021-03-18 08:35:48 | Query about 'initdb' error |