Re: [HACKERS] GSoC 2017: Foreign Key Arrays

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Mark Rofail <markm(dot)rofail(at)gmail(dot)com>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Joel Jacobson <joel(at)compiler(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Date: 2021-03-14 20:06:18
Message-ID: 20210314200618.GK29463@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 13, 2021 at 12:08:26PM +0200, Mark Rofail wrote:
> > I guess the failure is in the first patch, but isn't caught by test cases
> > until the 2nd patch
>
> This actually uncovered that I didn't add tests for the new operators in
> `gin.sql`, I have done so now, hopefully, that will help us uncover the
> problem. Can you post the regression results for the v8 patch attached
> below?

> +++ b/src/test/regress/expected/gin.out
> +select count(*) from gin_test_tbl where i @>> 1;
> + count
> +-------
> + 3
> +(1 row)
> +
> +select count(*) from gin_test_tbl where i @>> 999;
> + count
> +-------
> + 0
> +(1 row)

I think the expected results are actually wrong, with the linux CI failing but
actually returning the right results.

I have a fix which passes (modified) tests, although I doubt it's complete.

I think this patch will need additional review - more than I can give.

--
Justin

Attachment Content-Type Size
0001-anyarray_anyelement_operators.patch text/x-diff 29.4 KB
0002-fix.patch text/x-diff 1.3 KB
0003-fk_arrays_elems.patch text/x-diff 118.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-03-14 22:52:35 Re: fdatasync performance problem with large number of DB files
Previous Message Corey Huinker 2021-03-14 19:49:27 A Case For Inlining Immediate Referential Integrity Checks