| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Joel Jacobson <joel(at)compiler(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-03-12 23:11:16 |
| Message-ID: | 20210312231116.GI29463@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 12, 2021 at 11:32:27PM +0200, Mark Rofail wrote:
> I have retested the patch on a windows build and it passes the regression
> tests thanks to Justin's recommendations. Hopefully, it will pass CI too.
>
> Changelog:
> - v7 (compatible with current master 2021-3-12,
> commit 02b5940dbea17d07a1dbcba3cbe113cc8b70f228)
> * re-add failing regression test with fixes
> * rebase patch
This still fails for CI (windows) and me (linux):
SELECT ftest1 FROM FKTABLEFORARRAYGIN WHERE ftest1 @>> 5;
- ftest1
--------------
- {5}
- {3,5,2,5}
- {3,5,4,1,3}
- {5,1}
- {3,4,5,3}
-(5 rows)
+ ftest1
+--------
+(0 rows)
You added enable_seqscan=off, and EXPLAIN to show that it uses an bitmap index
scan, but do you know why it failed ?
I guess the failure is in the first patch, but isn't caught by test cases until
the 2nd patch.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-03-12 23:24:32 | Re: pg_amcheck contrib application |
| Previous Message | Robert Haas | 2021-03-12 22:55:35 | Re: pg_amcheck contrib application |