Re: [HACKERS] Custom compression methods

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-03-12 05:15:06
Message-ID: 20210312051506.GM8796@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 11, 2021 at 12:25:26PM -0600, Justin Pryzby wrote:
> On Wed, Mar 10, 2021 at 08:28:58PM -0600, Justin Pryzby wrote:
> > This includes a patch to use pkgconfig, in an attempt to build on mac, which
> > currently fails like:
> >
> > https://cirrus-ci.com/task/5993712963551232?command=build#L126
> > checking for LZ4_compress in -llz4... no
> > configure: error: library 'lz4' is required for LZ4 support
>
> This includes a 2nd attempt to use pkg-config to build on mac.
>
> If this doesn't work, we should ask for help from a mac user who wants to take
> on a hopefully-quick project.

The 2nd attempt passed ./configure on mac (and BSD after Thomas installed
pkg-config), but I eventually realized that LZ4 was effectively disabled,
because we set HAVE_LZ4, but the code tested instead WITH_LIBLZ4.

--
Justin

Attachment Content-Type Size
0001-Get-datum-from-tuple-which-doesn-t-contain-external-.patch text/x-diff 37.3 KB
0002-Expand-the-external-data-before-forming-the-tuple.patch text/x-diff 4.8 KB
0003-Disallow-compressed-data-inside-container-types.patch text/x-diff 10.6 KB
0004-Built-in-compression-method.patch text/x-diff 110.1 KB
0005-f-3nd-attempt-to-use-pkgconfig-to-allow-compiling-on.patch text/x-diff 13.6 KB
0006-Add-default_toast_compression-GUC.patch text/x-diff 11.4 KB
0007-Alter-table-set-compression.patch text/x-diff 20.2 KB
0008-default-to-with-lz4.patch text/x-diff 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-03-12 05:25:27 Re: About to add WAL write/fsync statistics to pg_stat_wal view
Previous Message vignesh C 2021-03-12 05:07:47 Re: [HACKERS] logical decoding of two-phase transactions