Re: [HACKERS] Custom compression methods

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-03-12 03:33:14
Message-ID: 20210312033314.GK8796@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 12, 2021 at 08:38:41AM +0530, Dilip Kumar wrote:
> On Thu, Mar 11, 2021 at 11:55 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > On Wed, Mar 10, 2021 at 08:28:58PM -0600, Justin Pryzby wrote:
> > > This includes a patch to use pkgconfig, in an attempt to build on mac, which
> > > currently fails like:
> > >
> > > https://cirrus-ci.com/task/5993712963551232?command=build#L126
> > > checking for LZ4_compress in -llz4... no
> > > configure: error: library 'lz4' is required for LZ4 support
> >
> > This includes a 2nd attempt to use pkg-config to build on mac.
> >
> > If this doesn't work, we should ask for help from a mac user who wants to take
> > on a hopefully-quick project.
>
> Thanks for your help. I did not understand the reason for removal of
> lz4.h header check?

It can stay. I tried to base this on ICU and LIBXML, but I see now they both
have that.

> -if test "$with_lz4" = yes; then
> - AC_CHECK_HEADERS(lz4/lz4.h, [],
> - [AC_CHECK_HEADERS(lz4.h, [], [AC_MSG_ERROR([lz4.h header file
> is required for LZ4])])])
> -fi
> -

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuro Yamada 2021-03-12 03:35:08 Re: Huge memory consumption on partitioned table with FKs
Previous Message Bruce Momjian 2021-03-12 03:31:28 Re: Key management with tests