Re: libpq debug log

At Thu, 11 Mar 2021 03:01:16 +0000, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> wrote in
> From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> > The output functions copy message bytes into local variable but the
> > same effect can be obtained by just casing via typed pointer type.
> >
> > uint32 tmp4;
> > ..
> > memcpy(&tmp4, buf + *cursor, 4);
> > result = (int) pg_ntoh32(tmp4);
> >
> > can be written as
> >
> > result = pg_ntoh32(* (uint32 *) (buf + *cursor));
>
> I'm afraid we need to memcpy() because of memory alignment.

Right. So something like this?

unsigned char p;

p = buf + *cursor;
result = (uint32) (*p << 24) + (*(p + 1)) << 16 + ...);

> > I think we can get rid of copying in the output functions for String
> > and Bytes in different ways.
>
> I haven't looked at this code, but you sound right.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center