Re: shared-memory based stats collector

At Mon, 8 Mar 2021 21:55:31 +0500, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote in
> The code does not compile and has compilation warnings and errors.
>
>
> ------
> pgstat.c:446:25: note: ‘cached_slrustats’ declared here
> static PgStat_SLRUStats cached_slrustats;
> ^~~~~~~~~~~~~~~~
> guc.c:4372:4: error: use of undeclared identifier 'pgstat_temp_directory';
> did you mean 'pgstat_stat_directory'?
> &pgstat_temp_directory,
> ^~~~~~~~~~~~~~~~~~~~~
> pgstat_stat_directory
> ../../../../src/include/pgstat.h:922:14: note: 'pgstat_stat_directory'
> declared here
> extern char *pgstat_stat_directory;
> ^
> guc.c:4373:3: error: use of undeclared identifier 'PG_STAT_TMP_DIR'
> PG_STAT_TMP_DIR,
> ^
> guc.c:4374:25: error: use of undeclared identifier
> 'assign_pgstat_temp_directory'
> check_canonical_path, assign_pgstat_temp_directory, NULL

Thanks! That's a stupid bug sneaked in by past rebasing and somehow
had lurked outside my sight.

The attached is a new version of this patchset.

- Amendmentof Fujii-san's comments (in 0003-Make-archiver..)

- Fix removal of pgstat_temp_directory.

- Fixed a bug in EXEC_BACKEND build.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center