Add .log file ending to tap test log files

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Add .log file ending to tap test log files
Date: 2021-03-04 19:24:00
Message-ID: 20210304192400.yqmczggp7ch4wujo@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Right now it's harder than necessary to capture the log output from tap
tests because the the regression tests files don't end with a common
file ending with other types of logs. They're
# Open the test log file, whose name depends on the test name.
$test_logfile = basename($0);
$test_logfile =~ s/\.[^.]+$//;
$test_logfile = "$log_path/regress_log_$test_logfile";

This was essentially introduced in 1ea06203b82: "Improve logging of TAP tests."

Would anybody object to replacing _logfile with .log? I realize that'd
potentially would cause some short-term pain on the buildfarm, but I
think it'd improve things longer term.

Greetings,

Andres Freund

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-03-04 19:24:09 Re: [HACKERS] PATCH: Batch/pipelining support for libpq
Previous Message Joel Jacobson 2021-03-04 19:16:10 Re: Allow matching whole DN from a client certificate