Re: Fix DROP TABLESPACE on Windows with ProcSignalBarrier?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix DROP TABLESPACE on Windows with ProcSignalBarrier?
Date: 2021-03-03 22:21:31
Message-ID: 20210303222131.u6yl5lijm2r76krh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-03-02 00:54:49 +1300, Thomas Munro wrote:
> Subject: [PATCH v6] Use a global barrier to fix DROP TABLESPACE on Windows.

After finally getting the windows CI tests to work on AIO I noticed that
the windows tests show the following:
https://cirrus-ci.com/task/4536820663844864

...
============================================================
Checking dummy_seclabel
C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/Debug/pg_regress/pg_regress --bindir=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/Debug/psql --dbname=contrib_regression dummy_seclabel
(using postmaster on localhost, default port)
============== dropping database "contrib_regression" ==============
WARNING: could not remove file or directory "base/16384": Directory not empty
...

which makes sense - the exact same problem exists for DROP DATABASE.

I suspect it makes sense to tackle the problem as part of the same
commit, but I'm not opposed to splitting it if that makes sense...

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Rofail 2021-03-03 22:22:03 Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Previous Message Thomas Munro 2021-03-03 22:19:54 Re: Fix DROP TABLESPACE on Windows with ProcSignalBarrier?