From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: buildfarm windows checks / tap tests on windows |
Date: | 2021-03-03 21:42:09 |
Message-ID: | 20210303214209.q2ltgfrxmsmtximb@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2021-03-03 16:07:13 -0500, Andrew Dunstan wrote:
> Here's what I actually got working. Rip out the calls to kill_kill and
> replace them with:
>
>
> $psql_primary{stdin} .= "\\q\n";
> $psql_primary{run}->pump_nb();
> $psql_standby{stdin} .= "\\q\n";
> $psql_standby{run}->pump_nb();
> sleep 2; # give them time to quit
>
>
> No hang or signal now.
Hm. I wonder if we can avoid the sleep 2 by doing something like
->pump(); ->finish(); instead of one pump_nb()? One pump() is needed to
send the \q to psql, and then we need to wait for the process to finish?
I'll try that, but given that I can't reproduce any problems...
I suspect that at least the crash recovery test suffers from exactly the
same problem and that we can re-enable it on windows after doign an
equivalent change...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-03-03 21:47:17 | Re: TRIM_ARRAY |
Previous Message | Mark Rofail | 2021-03-03 21:31:49 | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |