Re: [PATCH] Bug fix in initdb output

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Bug fix in initdb output
Date: 2021-03-02 14:32:48
Message-ID: 20210302143248.GA18366@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Mar-02, Nitin Jadhav wrote:

> > FWIW, I don't think that it is a good idea to come back to this
> > decision for *nix platforms, so I would let it as-is, and use
> > relative paths if initdb is called using a relative path.
>
> The command to be displayed either in absolute path or relative path
> depends on the way the user is calling initdb. I agree with the above
> comment to keep this behaviour as-is, that is if the initdb is called
> using relative path, then it displays relative path otherwise absolute
> path.

Yeah.

> > However, if you can write something that makes the path printed
> > compatible for a WIN32 terminal while keeping the behavior
> > consistent with other platforms, people would have no objections to
> > that.
>
> I feel the patch attached above handles this scenario.

Agreed. I'll push the original patch then. Thanks everybody for the
discussion.

--
Álvaro Herrera 39°49'30"S 73°17'W
"Porque francamente, si para saber manejarse a uno mismo hubiera que
rendir examen... ¿Quién es el machito que tendría carnet?" (Mafalda)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hamid Akhtar 2021-03-02 14:33:01 Re: psql crash while executing core regression tests
Previous Message Amul Sul 2021-03-02 14:24:15 Re: [Patch] ALTER SYSTEM READ ONLY