| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | tsunakawa(dot)takay(at)fujitsu(dot)com |
| Cc: | iwata(dot)aya(at)fujitsu(dot)com, k(dot)jamison(at)fujitsu(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: libpq debug log |
| Date: | 2021-02-26 08:37:32 |
| Message-ID: | 20210226.173732.611005044240961170.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Fri, 26 Feb 2021 17:30:32 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Fri, 26 Feb 2021 16:12:39 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > This inhibits logCursor being updated. What is worse, I find that
> > logCursor movement is quite dubious.
>
> Using (inCursor - inStart) as logCursor doesn't work correctly if
> tracing state desyncs. Once desync happens inStart can be moved at
> the timing that the tracing code doesn't expect.
- This requires (as I
- mentioned upthread) pqReadData to actively reset logCursor, though.
+ So pgReadData needs to avtively reset logCursor. If logCursor is
+ actively reset, we no longer need to use (inCursor - inStart) as
+ logCursor and it is enough that logCursor follows inCursor.
>
> logCursor should move when bytes are fed to the tracing functoins even
> when theyare the last bytes of a message.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2021-02-26 08:38:12 | RE: libpq debug log |
| Previous Message | Kyotaro Horiguchi | 2021-02-26 08:30:32 | Re: libpq debug log |