| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Snapshot scalability patch issue |
| Date: | 2021-02-16 01:30:12 |
| Message-ID: | 20210216013012.5cjmebjcqyqtx3wp@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-02-15 15:08:40 -0800, Andres Freund wrote:
> On 2021-02-14 18:42:18 -0800, Peter Geoghegan wrote:
> > The call to heap_page_prune() within lazy_scan_heap() passes a bool
> > literal ('false') as its fourth argument. But the fourth argument is
> > of type TransactionId, not bool. This has been the case since the
> > snapshot scalability work performed by commit dc7420c2c92. Surely
> > something is amiss here.
>
> Looks like I accidentally swapped the InvalidTransactionId and false
> around - luckily they have the same actual bit pattern...
>
> I do wish C could pass arguments by name.
>
> I'll push something once I'm back at my computer...
Done. Thanks for noticing/reporting!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-02-16 01:30:45 | Re: Snapshot scalability patch issue |
| Previous Message | Aleksei Ivanov | 2021-02-16 01:25:55 | Fwd: Row description Metadata information |