Re: [HACKERS] Custom compression methods

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-02-14 18:49:40
Message-ID: 20210214184940.GL1793@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 10, 2021 at 04:56:17PM -0500, Robert Haas wrote:
> Small delta patch with a few other suggested changes attached.

Robert's fixup patch caused the CI to fail, since it 1) was called *.patch;
and, 2) didn't include the previous patches.

This includes a couple proposals of mine as separate patches.

. psql: Add HIDE_COMPRESSAM for regress testing; I'm proposing this as part of
0001 (I excluded the reression test changes from 0001 which would've been
reverted by this patch).
. Add default_toast_compression GUC with ideas from Robert; I'm proposing
something like this as part of 0001. Actually, the full complexity with syscache
lookups and invalidation aren't needed in 0001, but are needed in the
"Custom compression" patch.
. default --enable-lz4 (this not meant to be merged so you could leave this as
a separate patch)

I'm not including the whole patch series, since this patch is failing
pg_restore tests:
|Create custom compression methods

--
Justin

Attachment Content-Type Size
v24-0001-Built-in-compression-method.patch text/x-diff 116.2 KB
v24-0002-psql-Add-HIDE_COMPRESSAM-for-regress-testing.patch text/x-diff 4.3 KB
v24-0003-Add-default_toast_compression-GUC.patch text/x-diff 10.4 KB
v24-0004-default-to-with-lz4.patch text/x-diff 934 bytes
v24-0005-fixups.patch.patch text/x-diff 6.4 KB
v24-0006-alter-table-set-compression.patch text/x-diff 29.3 KB
v24-0007-Add-support-for-PRESERVE.patch text/x-diff 52.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-02-14 20:28:31 Re: [HACKERS] Custom compression methods
Previous Message Dave Cramer 2021-02-14 17:35:48 Re: Extensibility of the PostgreSQL wire protocol