Re: Removing support for COPY FROM STDIN in protocol version 2

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removing support for COPY FROM STDIN in protocol version 2
Date: 2021-02-04 15:25:48
Message-ID: 20210204152548.GA6658@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Feb-04, Tom Lane wrote:

> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > On 2021-Feb-04, Heikki Linnakangas wrote:
> >> Ok, here we go.
>
> > Are you going to bump the .so version for this? I think that should be
> > done, since some functions disappear and there are struct changes. It
> > is curious, though, to see that exports.txt needs no changes.
>
> Uh, what? There should be no externally visible ABI changes in libpq
> (he says without having read the patch). If there's a need for a library
> major version bump, that'd be sufficient reason not to do this IMO.

Yeah, the changes I was thinking about are all in libpq-int.h so that's
not really a problem. But one enum in libpq-fe.h renumbers values, and
I think it's better to keep the old value labelled as "unused" to avoid
any changes.

--
Álvaro Herrera Valdivia, Chile

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-02-04 15:31:49 Re: get rid of <foreignphrase> tags in the docs?
Previous Message Alvaro Herrera 2021-02-04 15:23:53 Re: Snapbuild woes followup