| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Printing backtrace of postgres processes |
| Date: | 2021-01-27 17:09:58 |
| Message-ID: | 20210127170958.vzo33jzmqwhmn7z6@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-01-27 19:05:16 +0530, vignesh C wrote:
> /*
> + * LogBackTrace
> + *
> + * Get the backtrace and log the backtrace to log file.
> + */
> +void
> +LogBackTrace(void)
> +{
> + int save_errno = errno;
> +
> + void *buf[100];
> + int nframes;
> + char **strfrms;
> + StringInfoData errtrace;
> +
> + /* OK to process messages. Reset the flag saying there are more to do. */
> + PrintBacktracePending = false;
ISTM that it'd be better to do this in the caller, allowing this
function to be used outside of signal triggered backtraces.
>
> +extern void LogBackTrace(void); /* Called from EmitProcSignalPrintCallStack */
I don't think this comment is correct anymore?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-01-27 17:35:30 | Re: cleaning up a few CLOG-related things |
| Previous Message | Konstantin Knizhnik | 2021-01-27 16:51:32 | Improve join selectivity estimation using extended statistics |