From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Luc Vlaming <luc(at)swarm64(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com> |
Subject: | Re: should INSERT SELECT use a BulkInsertState? |
Date: | 2021-01-20 09:11:13 |
Message-ID: | 20210120091113.GP8560@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 05, 2020 at 01:59:41PM -0600, Justin Pryzby wrote:
> On Thu, Dec 03, 2020 at 10:59:34AM +0530, Bharath Rupireddy wrote:
> > On Wed, Dec 2, 2020 at 10:24 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > >
> > > One loose end in this patch is how to check for volatile default expressions.
> >
> > I think we should be doing all the necessary checks in the planner and
> > have a flag in the planned stmt to indicate whether to go with multi
> > insert or not. For the required checks, we can have a look at how the
> > existing COPY decides to go with either CIM_MULTI or CIM_SINGLE.
>
> Yes, you can see that I've copied the checks from copy.
> Like copy, some checks are done once, in ExecInitModifyTable, outside of the
> ExecModifyTable "loop".
>
> This squishes some commits together.
> And uses bistate for ON CONFLICT.
> And attempts to use memory context for tuple size.
Rebased on 9dc718bdf2b1a574481a45624d42b674332e2903
I guess my patch should/may be subsumed by this other one - I'm fine with that.
https://commitfest.postgresql.org/31/2871/
Note that my interest here is just in bistate, to avoid leaving behind many
dirty buffers, not improved performance of COPY.
--
Justin
Attachment | Content-Type | Size |
---|---|---|
v9-0001-INSERT-SELECT-to-use-BulkInsertState-and-multi_in.patch | text/x-diff | 46.9 KB |
v9-0002-WIP-Check-for-volatile-defaults.patch | text/x-diff | 7.3 KB |
v9-0003-COPY-flush-multi-insert-buffer-based-on-accumulat.patch | text/x-diff | 1.7 KB |
v9-0004-WIP-check-tuple-size.patch | text/x-diff | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2021-01-20 09:14:54 | Re: pg_stat_statements oddity with track = all |
Previous Message | Pavel Stehule | 2021-01-20 08:43:09 | Re: Rethinking plpgsql's assignment implementation |