Re: Key management with tests

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Subject: Re: Key management with tests
Date: 2021-01-10 14:51:16
Message-ID: 20210110145116.GE19555@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 10, 2021 at 06:04:12PM +1300, Thomas Munro wrote:
> On Sun, Jan 10, 2021 at 3:45 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Does anyone know why the cfbot applied the patch listed second first
> > here?
> >
> > http://cfbot.cputube.org/patch_31_2925.log
> >
> > Specifically, it applied hex..key.diff.gz before hex.diff.gz. I assumed
> > it would apply attachments in the order they appear in the email.
>
> It sorts the filenames (in this case after decompressing step removes
> the .gz endings). That works pretty well for the patches that "git
> format-patch" spits out, but it's a bit hit and miss with cases like
> yours.

OK, here they are with numeric prefixes. It was actually tricky to
figure out how to create a squashed format-patch based on another branch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachment Content-Type Size
01-hex.diff.gz application/gzip 3.6 KB
02-hex..key.diff.gz application/gzip 120.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2021-01-10 15:36:49 Re: support for MERGE
Previous Message Wang, Shenhao 2021-01-10 12:57:53 invalid data in file backup_label problem on windows