Re: [PATCH] Simple progress reporting for COPY command

On Wed, Jan 06, 2021 at 10:44:49PM +0100, Tomas Vondra wrote:
> On 1/5/21 11:02 AM, Josef Šimánek wrote:
> > I'm attaching the whole patch since commitfest failed to ingest the
> > last incremental on CI.
> >
>
> Yeah, the whole patch needs to be attached for the commitfest tester to work
> correctly - it can't apply pieces from multiple messages, etc.
>
> Anyway, I pushed this last version of patch, after a couple more tweaks,
> mainly to the docs - one place used pg_stat_copy_progress, the section was
> not indexed properly, and so on.

Some more doc fixes.

From 0616f448057905ab9b3218ebddfdd3af52e62bac Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj(at)telsasoft(dot)com>
Date: Wed, 6 Jan 2021 19:08:11 -0600
Subject: [PATCH] doc review: COPY progress:
8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f

---
doc/src/sgml/monitoring.sgml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
Whenever <command>COPY</command> is running, the
<structname>pg_stat_progress_copy</structname> view will contain one row
- for each backend that is currently running <command>COPY</command> command.
- The table bellow describes the information that will be reported and provide
- information how to interpret it.
+ for each backend that is currently running a <command>COPY</command> command.
+ The table below describes the information that will be reported and provides
+ information about how to interpret it.
</para>

<table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,

<row>
<entry role="catalog_table_entry"><para role="column_definition">
- <structfield>datid</structfield> <type>text</type>
+ <structfield>datid</structfield> <type>oid</type>
</para>
<para>
OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
</para>
<para>
OID of the table on which the <command>COPY</command> command is executed.
- It is set to 0 if <command>SELECT</command> query is provided.
+ It is set to 0 if copying from a <command>SELECT</command> query.
</para></entry>
</row>

--
2.17.0