Re: Online checksums patch - once again

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Online checksums patch - once again
Date: 2021-01-05 20:40:04
Message-ID: 20210105204004.GL1849@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 05, 2021 at 09:29:31PM +0100, Michael Banck wrote:
> > @@ -4938,13 +4949,299 @@ GetMockAuthenticationNonce(void)
> > /*
> > - * Are checksums enabled for data pages?
> > + * DataChecksumsNeedWrite
> > + * Returns whether data checksums must be written or not
> > + *
> > + * Are checksums enabled, or in the process of being enabled, for data pages?
>
> The second "," looks odd and could be ommitted?.

Maybe write:

> > + * Are checksums on data pages enabled, or in the process of being enabled ?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-01-05 21:11:07 Re: set_config() documentation clarification
Previous Message Pavel Stehule 2021-01-05 20:34:42 Re: set_config() documentation clarification