Re: doc review for v14

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: doc review for v14
Date: 2020-12-27 20:26:05
Message-ID: 20201227202604.GC26311@telsasoft.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 24, 2020 at 05:12:02PM +0900, Michael Paquier wrote:
> I have applied most of it on HEAD, except 0011 and the things noted
> above. Thanks again.

Thank you.

I see that I accidentally included ZSTD_COMPRESSION in pg_backup_archiver.h
while cherry-picking from the branch where I first fixed this. Sorry :(

> 0001-pgindent-typos.not-a-patch touches pg_bsd_indent.

I'm hoping that someone will apply it there, but I realize that access to its
repository is tightly controlled :)

On Thu, Dec 24, 2020 at 05:12:02PM +0900, Michael Paquier wrote:
> Restraining more the set of options is something to consider, though
> it could be annoying. I have discarded this one for now.

Even though its -d is unused, I guess since wouldn't serve any significant
purpose, we shouldn't make pg_restore -l -d fail for no reason.

I think a couple of these should be backpatched.
doc/src/sgml/ref/pg_dump.sgml
doc/src/sgml/sources.sgml
doc/src/sgml/cube.sgml?
doc/src/sgml/func.sgml?

--
Justin

Attachment Content-Type Size
0001-typos-in-master.patch text/x-diff 950 bytes
0002-producement-fcec6caafa2346b6c9d3ad5065e417733bd63cd9.patch text/x-diff 1.5 KB
0003-cannot.patch text/x-diff 1.1 KB
0004-Doc-review-for-min_dynamic_shared_memory-84b1c63ad.patch text/x-diff 1.5 KB
0005-Doc-review-for-pg_stat_replication_slots-986816750.patch text/x-diff 4.5 KB
0006-pg_restore-must-be-specified-and-list.patch text/x-diff 1.7 KB
0007-Remove-ZSTD_COMPRESSION-accidentially-included-at-90.patch text/x-diff 850 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Eric Hanson 2020-12-27 22:59:08 Re: Feature request: Connection string parsing for postgres_fdw
Previous Message Peter Geoghegan 2020-12-27 20:16:50 vacuum_cost_page_miss default value and modern hardware