Re: pgsql: Add key management system

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add key management system
Date: 2020-12-25 20:12:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Fri, Dec 25, 2020 at 02:53:10PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Fri, Dec 25, 2020 at 02:37:06PM -0500, Tom Lane wrote:
> >> pg_attribute_noreturn() seems like a good idea, but we're also going to
> >> need dummy return statements in the callers, to satisfy compilers that
> >> don't understand that.
> > Yes, done. I tested it with a non-OpenSSL configure run now and it
> > worked. Thanks for the report.
> Now that it compiles cleanly, what about test cases? It looks
> to me like you broke src/test/Makefile:
> @@ -30,7 +30,7 @@ endif
> endif
> ifeq ($(with_openssl),yes)
> ifneq (,$(filter ssl,$(PG_TEST_EXTRA)))
> -SUBDIRS += ssl
> +SUBDIRS += ssl crypto
> endif
> endif

Odd I am running the regression tests.

> because there is no such subdirectory. Assuming that that's a
> case of forgetting to "git add" the whole subdirectory, I still
> don't much care for this implementation: the user should be able
> to decide which subdirectories get run. Maybe more like
> ifeq ($(with_openssl),yes)
> ifneq (,$(filter ssl,$(PG_TEST_EXTRA)))
> SUBDIRS += ssl
> endif
> +ifneq (,$(filter crypto,$(PG_TEST_EXTRA)))
> +SUBDIRS += crypto
> +endif
> endif

There are no tests yet. I need to write those in TAP, and I am going to
wait until I have something more substantial to test. I do have a test
framework here I am using.

Bruce Momjian <bruce(at)momjian(dot)us>

The usefulness of a cup is in its emptiness, Bruce Lee

In response to


Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-25 20:13:28 pgsql: remove missing reference to crypto test from patch 978f869b99
Previous Message Tom Lane 2020-12-25 19:53:10 Re: pgsql: Add key management system

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2020-12-25 20:26:30 Re: SQL/JSON: functions
Previous Message Andres Freund 2020-12-25 20:09:53 Pre-allocating WAL files