Re: Deadlock between backend and recovery may not be detected

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: masao(dot)fujii(at)oss(dot)nttdata(dot)com
Cc: sawada(dot)mshk(at)gmail(dot)com, bdrouvot(at)amazon(dot)com, vyegorov(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Deadlock between backend and recovery may not be detected
Date: 2020-12-25 04:16:11
Message-ID: 20201225.131611.1914966836446852743.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 23 Dec 2020 21:42:47 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
> you. Attached
> is the updated of the patch. What about this version?

The patch contains a hunk in the following structure.

+ if (got_standby_lock_timeout)
+ goto cleanup;
+
+ if (got_standby_deadlock_timeout)
+ {
...
+ }
+
+cleanup:

It is eqivalent to

+ if (!got_standby_lock_timeout && got_standby_deadlock_timeout)
+ {
...
+ }

Is there any reason for the goto?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2020-12-25 04:24:37 Re: Parallel Inserts in CREATE TABLE AS
Previous Message Tang, Haiying 2020-12-25 03:58:11 RE: [Patch] Optimize dropping of relation buffers using dlist