Re: BUG #16079: Question Regarding the BUG #16064

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, k(dot)yudhveer(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #16079: Question Regarding the BUG #16064
Date: 2020-12-21 18:35:11
Message-ID: 20201221183511.GI27507@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> > On Sun, Dec 20, 2020 at 7:58 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> >> * Magnus Hagander (magnus(at)hagander(dot)net) wrote:
> >>> Maybe we should do the same for LDAP (and RADIUS)? This seems like a
> >>> better place to put it than to log it at every time it's received?
>
> >> A dollar short and a year late, but ... +1.
>
> > I would suggest going further. I would make the change on the client side,
> > and have libpq refuse to send unhashed passwords without having an
> > environment variable set which allows it.
>
> As noted, that would break LDAP and RADIUS auth methods; likely also PAM.

Which would be an altogether good thing as all of those end up exposing
sensitive information should the server be compromised and a user uses
one of them to log in.

The point would be to make it clear to the user, while having an escape
hatch if necessary, that they're sending their password (or pin in the
RADIUS case) to the server.

> > What is the value of logging on the server side?
>
> I do agree with this point, but mostly on the grounds of "nobody reads
> the server log".

I agree that doing this server side really isn't all that helpful.

Thanks,

Stephen

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-12-21 18:44:02 Re: BUG #16079: Question Regarding the BUG #16064
Previous Message Tom Lane 2020-12-21 18:31:32 Re: BUG #16079: Question Regarding the BUG #16064

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-12-21 18:44:02 Re: BUG #16079: Question Regarding the BUG #16064
Previous Message Tom Lane 2020-12-21 18:31:32 Re: BUG #16079: Question Regarding the BUG #16064