| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Bernd Helmle <mailings(at)oopsware(dot)de>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change default of checkpoint_completion_target |
| Date: | 2020-12-10 17:22:55 |
| Message-ID: | 20201210172255.GQ16415@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Alvaro Herrera (alvherre(at)alvh(dot)no-ip(dot)org) wrote:
> On 2020-Dec-10, Stephen Frost wrote:
> > * Laurenz Albe (laurenz(dot)albe(at)cybertec(dot)at) wrote:
> > > On Tue, 2020-12-08 at 17:29 +0000, Bossart, Nathan wrote:
> > > > +1 to setting checkpoint_completion_target to 0.9 by default.
> > >
> > > +1 for changing the default or getting rid of it, as Tom suggested.
> >
> > Attached is a patch to change it from a GUC to a compile-time #define
> > which is set to 0.9, with accompanying documentation updates.
>
> I think we should leave a doc stub or at least an <indexterm>, to let
> people know the GUC has been removed rather than just making it
> completely invisible. (Maybe piggyback on the stuff in [1]?)
>
> [1] https://postgr.es/m/CAGRY4nyA=jmBNa4LVwgGO1GyO-RnFmfkesddpT_uO+3=mot8DA@mail.gmail.com
Yes, I agree, and am involved in that thread as well- currently waiting
feedback from others about the proposed approach.
Getting a few more people looking at that thread and commenting on it
would really help us be able to move forward.
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-12-10 17:32:52 | pg_basebackup test coverage |
| Previous Message | Alvaro Herrera | 2020-12-10 17:21:26 | Re: Change default of checkpoint_completion_target |