| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_dump, ATTACH, and independently restorable child partitions |
| Date: | 2020-12-04 18:02:31 |
| Message-ID: | 20201204180231.GD24052@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 04, 2020 at 12:13:05PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > [ v4-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ]
>
> The cfbot is being picky about this:
>
> 3218pg_dump.c: In function ‘dumpTableAttach’:
> 3219pg_dump.c:15600:42: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
> 3220 if (attachinfo->partitionTbl->dobj.dump & DUMP_COMPONENT_DEFINITION == 0)
> 3221 ^
> 3222cc1: all warnings being treated as errors
>
> which if I've got the precedence straight is indeed a bug.
Oops - from a last-minute edit.
I missed it due to cfboot being slow, and clogged up with duplicate entries.
This also adds/updates comments.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch | text/x-diff | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-12-04 18:25:21 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | Andrey Borodin | 2020-12-04 17:36:25 | Re: Logical archiving |