Re: SV: Problem with pg_notify / listen

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gustavsson Mikael <mikael(dot)gustavsson(at)smhi(dot)se>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Svensson Peter <peter(dot)svensson(at)smhi(dot)se>, Almen Anders <anders(dot)almen(at)smhi(dot)se>
Subject: Re: SV: Problem with pg_notify / listen
Date: 2020-11-28 04:10:01
Message-ID: 20201128041001.GB556656@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-general

On Fri, Nov 27, 2020 at 11:03:40PM -0500, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > I think we don't yet have the right name here, seeing QUEUE_TAIL_PAGE !=
> > QUEUE_POS_PAGE(QUEUE_TAIL) sounds paradoxical, yet happens regularly. How
> > about naming it QUEUE_STOP_PAGE?
>
> Hmm, it's not very clear what "stop" means here. What do you think of
> QUEUE_OLDEST_PAGE?

"STOP" would mean the same kind of thing it means in xidStopLimit,
multiStopLimit and offsetStopLimit. Interpreted for pg_notify specifically,
it would mean "if queueing a notification would require use of this page,
throw an error."

QUEUE_OLDEST_PAGE is fine. I like it a little less than QUEUE_STOP_PAGE,
because oldestClogXid is a logical tail, and QUEUE_OLDEST_PAGE would be a
physical tail.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-11-28 19:15:11 Re: SV: Problem with pg_notify / listen
Previous Message Tom Lane 2020-11-28 04:03:40 Re: SV: Problem with pg_notify / listen

Browse pgsql-general by date

  From Date Subject
Next Message Hemil Ruparel 2020-11-28 14:04:40 Re: How to debug authentication issues in Postgres
Previous Message Tom Lane 2020-11-28 04:03:40 Re: SV: Problem with pg_notify / listen