| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
| Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Date: | 2020-11-24 15:31:23 |
| Message-ID: | 20201124153123.GO24052@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 31, 2020 at 01:36:11PM -0500, Justin Pryzby wrote:
> > > From the grammar perspective ANY option is available for any command
> > > that uses parenthesized option list. All the checks and validations
> > > are performed at the corresponding command code.
> > > This analyze_keyword is actually doing only an ANALYZE word
> > > normalization if it's used as an option. Why it could be harmful?
> >
> > Michael has not replied since then, but he was relatively positive about
> > 0005 initially, so I put it as a first patch now.
>
> Thanks. I rebased Alexey's latest patch on top of recent changes to cluster.c.
> This puts the generic grammar changes first. I wasn't paying much attention to
> that part, so still waiting for a committer review.
@cfbot: rebased
| Attachment | Content-Type | Size |
|---|---|---|
| v30-0001-Refactor-gram.y-in-order-to-add-a-common-parenth.patch | text/x-diff | 4.8 KB |
| v30-0002-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch | text/x-diff | 19.0 KB |
| v30-0003-Allow-REINDEX-to-change-tablespace.patch | text/x-diff | 36.6 KB |
| v30-0004-Refactor-and-reuse-set_rel_tablespace.patch | text/x-diff | 6.6 KB |
| v30-0005-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch | text/x-diff | 23.4 KB |
| v30-0006-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch | text/x-diff | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-11-24 15:45:11 | Re: abstract Unix-domain sockets |
| Previous Message | Bruce Momjian | 2020-11-24 15:28:29 | Re: Prevent printing "next step instructions" in initdb and pg_upgrade |