bug in pageinspect's "tuple data" feature

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: bug in pageinspect's "tuple data" feature
Date: 2020-11-21 19:32:06
Message-ID: 20201121193206.GA32459@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

If you have a sufficiently broken data page, pageinspect throws an
error when trying to examine the page:

ERROR: invalid memory alloc request size 18446744073709551451

This is pretty unhelpful; it would be better not to try to print the
data instead of dying. With that, at least you can know where the
problem is.

This was introduced in d6061f83a166 (2015). Proposed patch to fix it
(by having the code print a null "data" instead of dying) is attached.

--
Álvaro Herrera

Attachment Content-Type Size
pginspect.patch text/x-diff 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-11-21 19:41:05 Re: [PATCH] remove pg_standby
Previous Message Andrew Dunstan 2020-11-21 19:14:22 Re: Connection using ODBC and SSL