| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] remove pg_archivecleanup and pg_standby |
| Date: | 2020-11-16 08:10:05 |
| Message-ID: | 20201116081005.GB19692@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 03, 2020 at 05:28:46PM +0200, Heikki Linnakangas wrote:
> Removing pg_standby has been proposed a couple of times in the past. See https://www.postgresql.org/message-id/20170913064824.rqflkadxwpboabgw@alap3.anarazel.de
> for the latest attempt.
>
> Masao-san, back in 2014 you mentioned "fast failover" as a feature that was
> missing from the built-in standby mode (https://www.postgresql.org/message-id/CAHGQGwEE_8vvpQk0ex6Qa_aXt-OSJ7OdZjX4uM_FtqKfxq5SbQ%40mail.gmail.com).
> I think that's been implemented since, with the recovery_target settings.
> Would you agree?
>
> I'm pretty sure we can remove pg_standby by now. But if there's something
> crucial missing from the built-in facilities, we need to talk about
> implementing them.
Reading the thread you are mentioning, it seems to me that the
statu-quo is the same, but I find rather scary that this tool is used
in exactly zero tests.
Echoing with Robert, I think that pg_archivecleanup is still useful in
many cases, so that's not something we should remove.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinoda, Noriyoshi (PN Japan FSI) | 2020-11-16 08:12:05 | Tab complete for CREATE OR REPLACE TRIGGER statement |
| Previous Message | Michael Paquier | 2020-11-16 07:56:06 | Re: PostmasterIsAlive() in recovery (non-USE_POST_MASTER_DEATH_SIGNAL builds) |