| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skip ExecCheckRTPerms in CTAS with no data |
| Date: | 2020-11-16 03:04:31 |
| Message-ID: | 20201116030431.GA4781@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 13, 2020 at 12:58:52PM +0530, Bharath Rupireddy wrote:
> It's not required to set bistate to null as we have allocated myState
> with palloc0 in CreateIntoRelDestReceiver, it will anyways be null.
> if (!into->skipData)
> myState->bistate = GetBulkInsertState();
>
> Attaching v4 patch. Please review it.
I have reviewed this one this morning, and applied it after some
tweaks. I have reworded some of the comments, fixed some typos, and
largely refactored the test cases to stress all the combinations
possible. Please note that your patch would have caused failures
in the buildfarm, as any role created needs to be prefixed with
"regress_".
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Seino Yuki | 2020-11-16 03:22:44 | Re: [PATCH] Add features to pg_stat_statements |
| Previous Message | Ian Lawrence Barwick | 2020-11-16 02:49:49 | Re: Corner-case bug in pg_rewind |