Re: Aw: Re: Minor documentation error regarding streaming replication protocol

On Thu, Oct 15, 2020 at 12:43:22PM -0400, Bruce Momjian wrote:
> On Thu, Oct 15, 2020 at 12:01:21PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > We would want the timeline history file contents label changed from
> > > BYTEA to TEXT in the docs changed for all supported versions, add a C
> > > comment to all backbranches that BYTEA is the same as TEXT protocol
> > > fields, and change the C code to return TEXT IN PG 14. Is that what
> > > people want?
> >
> > I still think there is no need to touch back branches. What you
> > propose here is more likely to confuse people than help them.
> > Having the documentation disagree with the code about how the
> > field is labeled is not good either.
>
> Understood.
>
> > Furthermore, it absolutely does not make sense to say (or imply)
> > that the unknown-encoding business applies to all text fields.
> > There are a very small number of fields where we should say that.
>
> Yes, I am seeing now that even IDENTIFY_SYSTEM above it properly does
> encoding. I guess TIMELINE_HISTORY works this way because it is pulling
> from the file system, not from system tables. I ended up with just a
> new doc sentence and C comment in back branches, and a relabeling of the
> timeline history 'content' field as TEXT in the C code and docs,
> attached.

I have applied the doc-only patch to back branches, and the data type
change to master; the master change should cause no behavioral change.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee