Re: Implementing Incremental View Maintenance

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, michael(at)paquier(dot)xyz, thomas(dot)munro(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, takuma(dot)hoshiai(at)gmail(dot)com, amitlangote09(at)gmail(dot)com, alvherre(at)2ndquadrant(dot)com, kgrittn(at)gmail(dot)com
Subject: Re: Implementing Incremental View Maintenance
Date: 2020-11-12 08:47:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, 5 Nov 2020 22:58:25 -0600
Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> On Mon, Oct 05, 2020 at 06:16:18PM +0900, Yugo NAGATA wrote:
> This needs to be rebased again - the last version doesn't apply anymore.

I attached the rebased patch (v19).

> I looked though it a bit and attach some fixes to the user-facing docs.

Thank you for pointing out a lot of typos and making the patch to fix it!
Your fixes are included in the latest patch.

> There's some more typos in the source that I didn't fix:
> constrains
> materliazied
> cluase
> immediaite
> clumn
> Temrs
> migth
> recalculaetd
> speified
> secuirty
> commit message: comletion
> psql and pg_dump say 13 but should say 14 now:
> pset.sversion >= 130000

These were also fixed.

> # bag union
> big union?

"bag union" is union operation of bag (multi-set) that does not eliminate duplicate of tuples.

> + <structfield>relisivm</structfield> <type>bool</type>
> + </para>
> + <para>
> + True if materialized view enables incremental view maintenance
> This isn't clear, but I think it should say "True for materialized views which
> are enabled for incremental view maintenance (IVM)."

Yes, you are right. I also fixed it in this way.

Yugo Nagata

Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
IVM_patches_v19.tar.gz application/gzip 79.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2020-11-12 08:58:01 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Georgios 2020-11-12 08:44:09 Re: Add session statistics to pg_stat_database