From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
Subject: | PG13: message style changes |
Date: | 2020-11-07 03:49:43 |
Message-ID: | 20201107034943.GA16596@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I propose to apply the following changes to messages in pg13.
In 0001, I propose changing messages that were introduced as different
for parallel vacuum workers. Frankly I don't understand why we are
bragging about the vacuum being done in a parallel worker; does the user
care? It seems to me that users are just satisfied to know that the
indexes were scanned; the fact that this was done in a parallel worker
is not of much interest, so why call attention to that? Therefore, we
can reduce the message to what's emitted in the normal case.
In 0002, I propose to remove the word "concurrently" in an error
message when an invalid index cannot be reindexed. In fact, the problem
is generic: we just cannot reindex the index at all, regardless of
concurrently or not. So we can reduce this message to be identical to
the one we throw in the non-concurrent case.
(Dropped 0003 while composing this email.)
Patch 0004 just adds a comment to clarify a message that I found
confusing when doing the translation.
--
Álvaro Herrera 39°49'30"S 73°17'W
Attachment | Content-Type | Size |
---|---|---|
0001-Simplify-message.patch | text/x-diff | 2.3 KB |
0002-Remove-concurrently-from-error-message.patch | text/x-diff | 1.3 KB |
0004-Make-message-less-obscure.patch | text/x-diff | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2020-11-07 03:57:16 | Re: Log message for GSS connection is missing once connection authorization is successful. |
Previous Message | Tom Lane | 2020-11-07 02:52:49 | Re: First-draft release notes for back branches are up |