| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: Split copy.c |
| Date: | 2020-11-02 18:34:54 |
| Message-ID: | 20201102183454.gbjpjfp2qiiyab26@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-02 19:43:38 +0200, Heikki Linnakangas wrote:
> On 02/11/2020 19:23, Andres Freund wrote:
> > On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> > > There isn't much common code between COPY FROM and COPY TO, so I propose
> > > that we split copy.c into two: copyfrom.c and copyto.c. See attached. I thin
> > > that's much nicer.
> >
> > Not quite convinced that's the right split - or perhaps there's just
> > more potential. My feeling is that splitting out all the DML related
> > code would make the code considerably easier to read.
>
> What do you mean by DML related code?
Basically all the insertion related code (e.g CopyMultiInsert*, lots of
code in CopyFrom()) and perhaps also the type input invocations.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-11-02 18:40:20 | Re: upcoming API changes for LLVM 12 |
| Previous Message | Jesse Zhang | 2020-11-02 18:28:33 | Re: upcoming API changes for LLVM 12 |