Re: Split copy.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: Split copy.c
Date: 2020-11-02 17:23:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> While looking at the parallel copy patches, it started to annoy me how large
> copy.c is.


> There isn't much common code between COPY FROM and COPY TO, so I propose
> that we split copy.c into two: copyfrom.c and copyto.c. See attached. I thin
> that's much nicer.

Not quite convinced that's the right split - or perhaps there's just
more potential. My feeling is that splitting out all the DML related
code would make the code considerably easier to read.



In response to

  • Split copy.c at 2020-11-02 09:03:29 from Heikki Linnakangas


Browse pgsql-hackers by date

  From Date Subject
Next Message Anastasia Lubennikova 2020-11-02 17:23:47 Re: [proposal] de-TOAST'ing using a iterator
Previous Message Andres Freund 2020-11-02 17:14:26 Re: Add table AM 'tid_visible'